Repository navigation
fix(datetime): parse 12 AM as midnight and 12 PM as noon - #7376
Closed
Harsh23Kashyap wants to merge 1 commit into
Closed
Harsh23Kashyap wants to merge 1 commit into
Harsh23Kashyap wants to merge 1 commit into
Conversation
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7376 +/- ##
==========================================
- Coverage 95.04% 95.02% -0.02%
==========================================
Files 619 620 +1
Lines 52012 52016 +4
Branches 9450 9452 +2
==========================================
- Hits 49434 49430 -4
Misses 2031 2031
- Partials 547 555 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7370
parse()turned a 12-hour time into 24-hour by adding 12 for PM and doing nothing for AM. That is wrong for the hour 12:12 AMis hour 0 and12 PMis hour 12. So12:xx AMparsed as noon and12:xx PMparsed as hour 24, which rolled over to the next day.format()already prints midnight as12 AM, so a formatted value did not round-trip.The fix takes the hour modulo 12 for AM, and modulo 12 plus 12 for PM. It covers the
AM,AM.,A.M.and matching PM spellings, since they share the same code.Reproduction (
TZ=UTC, the script from the issue)Before:
After:
Tests
Added to
datetime/parse_test.ts: 12 AM and 12 PM in all three spellings, 1 to 11 o'clock still parsing as before, and a round trip of every hour of the day throughformat()andparse()withhh:mm a.deno test datetime/passes (22 tests, 50 steps) withTZ=UTCandTZ=America/New_York. With only the formatter change reverted, the 12 AM/PM test and the round-trip test fail, and the 1 to 11 o'clock test passes.deno fmt --checkanddeno lintare clean on the folder.