Skip to content

Conversation

@dsherret
Copy link
Member

No need for this once we bundle @types/node.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bartlomieju pushed a commit to denoland/deno that referenced this pull request Dec 9, 2025
This adds a new "node" lib that's included by default and can be
excluded by providing a custom `"lib": [...]` typescript compiler option
without the `"node"` value.

If it detects a `@types/node` package in the files being type checked it
will skip injecting the `lib.node.d.ts` file.

* Uses `npm:@types/[email protected]`
* See tools/update_types_node.ts for the build script.
* denoland/deno_npm#127 (will integrate this one
later)
* denoland/typescript-go#16
* denoland/TypeScript#19 (last two commits)

Closes #30963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants