Repository navigation
fix(init): remove @denote/core/ prefix from generated deno.json - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scaffolded deno.json included "@denote/core/": "jsr:@denote/core@^0.0.7/" as an import map prefix. This caused a runtime failure when Vite loaded the bundled vite.config.ts: Deno's WHATWG import map resolver tried to resolve @denote/core/vite by applying the prefix mapping, which requires URL-parsing the suffix vite relative to jsr:@denote/core@^0.0.7/. That fails because jsr: is a non-hierarchical URL scheme with an opaque path — WHATWG URL relative resolution doesn't work against it.
PR #72 attempted to fix this by switching to @denote/core/vite.ts, but the root cause was the prefix entry itself, not the specifier form. The .ts suffix produced the same failure for the same reason.
The fix removes the @denote/core/ prefix entry entirely. Without it, Deno uses its native JSR resolver for @denote/core/vite: it recognises @denote/core as a JSR package, reads the package exports map ("./vite": "./vite.ts"), and resolves correctly. The CSS @import "@denote/core/styles.css" in styles.css is unaffected — CSS imports go through Vite's node_modules resolver, not the import map.