Fix, pipeline model with moe cause error when send grad #7055
Open
wukong1992 wants to merge 2 commits intodeepspeedai:masterfrom
Open
Fix, pipeline model with moe cause error when send grad #7055wukong1992 wants to merge 2 commits intodeepspeedai:masterfrom
wukong1992 wants to merge 2 commits intodeepspeedai:masterfrom
Conversation
… cause error when moe loss not in position 1
Contributor
Author
|
@tohtana Could you review the merge requests? |
Collaborator
|
Hi @wukong1992 - looks like your changes are failing the formatting check - could you either run the pre-commit formatter locally or take a look at the errors? It looks like your changes mean we can remove an import and flake8 caught that. |
Collaborator
|
Hi @wukong1992, Thank you for this great fix, and sorry for my late response. I wonder if some behaviors might change with this PR other than solving the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix, pipeline model with moe, send and recv grad use same buffer will cause error when moe loss not in position 1. Solution, activation and grad use diff buffer. BUG DETAIL: in forward, the grad_buf will allocate hidden_states,some
tensors(required_grad is false), moe_loss;in backward,only send act grad(floating point),so only hidden_states and moe loss's grads will be send, and forward and backward use same grad_buf. This will cause send and recv grad use diff dtype, and cause numerical error。