fix: correct error messages and outdated function references#131
Open
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Open
fix: correct error messages and outdated function references#131yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Conversation
Documentation fixes: - Update `get_mla_metadata` docstring to reference `flash_mla_with_kvcache` instead of the old name `flash_mla_with_kvcache_sm90` Error message fixes: - Fix typo in head_size_v error message: said "576" but should be "512" (the check validates head_size_v == 512) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes incorrect error messages and outdated documentation.
Fixes
Outdated function name in docstring (
flash_mla/flash_mla_interface.py)get_mla_metadatadocstring referenced the old function nameflash_mla_with_kvcache_sm90flash_mla_with_kvcacheWrong value in error message (
csrc/pybind.cpp:230)head_size_v == 512Test plan
🤖 Generated with Claude Code