Skip to content

Allow --adjust-vma=1234 in diff_flags#1898

Open
mkst wants to merge 7 commits intomainfrom
adjust-vma
Open

Allow --adjust-vma=1234 in diff_flags#1898
mkst wants to merge 7 commits intomainfrom
adjust-vma

Conversation

@mkst
Copy link
Copy Markdown
Collaborator

@mkst mkst commented Apr 6, 2026

This scratch has ["--adjust-vma=4096"] as diff_flags:

image

@mkst mkst marked this pull request as draft April 7, 2026 09:32
@mkst mkst marked this pull request as ready for review April 7, 2026 11:27
@mkst mkst requested a review from bates64 as a code owner April 7, 2026 11:27
@mkst
Copy link
Copy Markdown
Collaborator Author

mkst commented Apr 7, 2026

This also opens the door to allowing --disassemble= to be modified from the frontend too... Which might be worth doing in the short term (assuming the longer-term is to make some changes to asm-differ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bates64 bates64 Awaiting requested review from bates64 bates64 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mkst