Repository navigation
fix: parse ability m_bDisabled as a boolean - #465
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
{{AbilityIcon|Baba's Brew}}and{{AbilityIcon|Granny Long Legs}}render "Icon not found" on the wiki. Their ability keys (ability_baba_hexing_brew,ability_baba_bench_run) exist inability-data.jsonand resolve in localization, but neither name was present inresource-lookup.json.Root cause
Valve's source data stores
m_bDisabledas the string"false"for these two abilities, while most abilities either omit it or use a real boolean.AbilityParsercopied the raw value straight through (abilities/__main__.py), soIsDisabledbecame the truthy string"false".ResourceLookupParserthen hitif ability.get('IsDisabled'): continueand silently dropped both abilities.Fix
m_bDisabledvia the existingutils.string_utils.is_truthywhen parsing abilities, so it is always a real boolean. This also corrects the"IsDisabled": "false"string currently published inability-data.json.ResourceLookupParserto useis_truthyand log a warning if a hero-bound ability is skipped as disabled, so this class of silent drop is visible in future.Parsed data in deadlock-data PR - Reopen deadbot PR or run deploy workflow for this branch here to reparse the data