Skip to content

fix: parse ability m_bDisabled as a boolean - #465

Merged
LVL1024 merged 3 commits into
masterfrom
hotfix/baba-ability-lookup
Oct 8, 2026
Merged

LVL1024 merged 3 commits into
masterfrom
hotfix/baba-ability-lookup

Conversation

@LVL1024

@LVL1024 LVL1024 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

{{AbilityIcon|Baba's Brew}} and {{AbilityIcon|Granny Long Legs}} render "Icon not found" on the wiki. Their ability keys (ability_baba_hexing_brew, ability_baba_bench_run) exist in ability-data.json and resolve in localization, but neither name was present in resource-lookup.json.

Root cause

Valve's source data stores m_bDisabled as the string "false" for these two abilities, while most abilities either omit it or use a real boolean.

AbilityParser copied the raw value straight through (abilities/__main__.py), so IsDisabled became the truthy string "false". ResourceLookupParser then hit if ability.get('IsDisabled'): continue and silently dropped both abilities.

Fix

  • Normalize m_bDisabled via the existing utils.string_utils.is_truthy when parsing abilities, so it is always a real boolean. This also corrects the "IsDisabled": "false" string currently published in ability-data.json.
  • Harden ResourceLookupParser to use is_truthy and log a warning if a hero-bound ability is skipped as disabled, so this class of silent drop is visible in future.

Parsed data in deadlock-data PR - Reopen deadbot PR or run deploy workflow for this branch here to reparse the data

@LVL1024
LVL1024 merged commit ad11d59 into master Oct 8, 2026
3 checks passed
@LVL1024
LVL1024 deleted the hotfix/baba-ability-lookup branch October 8, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants