Repository navigation
fix: exclude generic melee ability from changelog icons - #464
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Oct 6 update added Baba, and with it a generic ability,
ability_baba_bench_melee(part of the Granny Long Legs ability), that localizes to just "Melee". The changelog formatter treats every active ability name as an icon target, so the ordinary word "Melee", and phrases like "Heavy Melee", "Melee Resist" and "Melee Lifesteal", started rendering as{{AbilityIcon|Melee}}. Hero lines mentioning it were also promoted into aMeleesub-section. Because changelogs are reformatted from their stored raw text on every run, this retroactively rewrote several historical changelog files.Generic game-mechanic ability names are now excluded from the ability icon/link terms, leaving "Melee" as plain text. This also restores items such as
{{ItemIcon|Melee Lifesteal}}, which were being overridden because abilities are matched before items.Parsed data in deadlock-data PR - Reopen deadbot PR or run deploy workflow for this branch here to reparse the data