feat(download-ddev): add tag: and pr: values, stop compiling HEAD - #68
Merged
Conversation
## The Issue `ddev_version: HEAD` used `brew install --HEAD`, which compiled ddev from source on every run. Only `stable` and `HEAD` could be tested. ## How This PR Solves The Issue Homebrew always installs stable, then `ddev utility download-ddev` downloads the requested build into `$RUNNER_TEMP/ddev-bin` and prepends it to `PATH`. `ddev_version` also accepts `tag:<version>` and `pr:<number>` now. ## Manual Testing Instructions Run the add-ons test workflow with `ddev_version` set to `stable`, `HEAD`, `tag:v1.25.4` and `pr:<number>`. The new `Show ddev version` step prints which build was used. ## Automated Testing Overview The matrix covers `stable` and `HEAD`, plus one job for `tag:v1.25.4`. It no longer runs every add-on, `ddev-add-on-monitoring` does that. ## Release/Deployment Notes `CHANGELOG.md` has a v2.6.0 entry, its PR links need the real number. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
All HEAD tests always took about 2 extra minutes compared to stable. A win for GitHub and a win for us 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
ddev_version: HEADusedbrew install --HEAD, which compiled ddev from source on every run. OnlystableandHEADcould be tested.How This PR Solves The Issue
Homebrew always installs stable, then
ddev utility download-ddevdownloads the requested build into$RUNNER_TEMP/ddev-binand prepends it toPATH.ddev_versionalso acceptstag:<version>andpr:<number>now.Manual Testing Instructions
Run the add-ons test workflow with
ddev_versionset tostable,HEAD,tag:v1.25.4andpr:<number>. The newShow ddev versionstep prints which build was used.Automated Testing Overview
The matrix covers
stableandHEAD, plus one job fortag:v1.25.4. It no longer runs every add-on,ddev-add-on-monitoringdoes that.Release/Deployment Notes
Don't create releases manually. Follow the release process documentation when making a new release.