Open
Conversation
|
Would very much like this merged. |
Remove drift from job scheduling, by basing the next run time off the last *scheduled* run time, instead of `datetime.datetime.now()`. Additionally, `idle_seconds` is enforced to be non-negative, since it is now possible for `next_run` to be just before `now()`.
|
Is there any update on this? |
|
Do we have plan to merge this? This makes more sense especially if the task takes long to run (and the running time may vary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to remove drift from job scheduling, by basing the next run time off the
last scheduled run time, instead of
datetime.datetime.now().One perhaps nice possibility this PR opens up is, since the next scheduled time would be based on the previous scheduled time, one could store and restore the
.last_runbetween invocations of a schedule script to let it pick up from where it left off.