Repository navigation
docs: fix backslashes in fluent builder example - #102
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #92.
The fluent builder adds one backslash path separator, but the README passes a verbatim C# string containing two backslashes to
IsMatch. The example therefore returnsfalse, contrary to its comment.Use a single backslash in both the displayed glob pattern and the verbatim subject string. No runtime behavior changes.
Validation
falseagainst current develop source.trueandglob.ToString()equals the corrected displayed pattern.The probe used .NET 10 with
SPANenabled and isolated local configuration/cache paths; the repository's pinned .NET 8 SDK is not installed here. The full upstream test suite, legacy target frameworks and benchmarks were not run. This is a documentation-only change.