New option for estimating number of pages#110
Open
bkepps wants to merge 3 commits intodavidgiven:masterfrom
Open
New option for estimating number of pages#110bkepps wants to merge 3 commits intodavidgiven:masterfrom
bkepps wants to merge 3 commits intodavidgiven:masterfrom
Conversation
Author
|
Do I need to close this pull request myself? I saw that you closed the related issue a while back, but not this pull request. I'm new to contributing to open source, so I don't really know how these things work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two more options to the page count settings
when pagesbylines is true, wordsperpage is ignored and linesperpage is used to calculate the number of pages, and vice versa
The number of lines is kept track of at the bottom of src/lua/redraw.lua by totaling the number of lines returned by wrap() for each paragraph. This is then stored in Document.linecount.