Date filtering, transaction details, and per-transaction tag classification [3/6]

[terryaney]

Title: Date filtering, transaction details, and per-transaction tag classification [3/6]

[3/6] Based on feature/report-json-determinism (#99).
Merging this PR into main also lands #98 and #99 if not already merged.
This layer only: feature/report-json-determinism...feature/ui-tweaks

This PR fixes a data correctness bug in the HTML report and adds date filtering, transaction details, and layout polish.

Screenshots below are from simulated data — visual reference only.

Data Correctness Fix

Charts, Filtered View totals, and Section View percentages previously classified transactions using merchant.tags (the union across all transactions for that merchant). One income or transfer transaction could misclassify every other transaction at the same merchant. This PR switches to per-transaction txn.tags, matching the Python-side KPI logic.

Changes

• Per-transaction tag classification for charts, Filtered View, and Section View percentages
• Month / Quarter / Year / Custom date filtering with URL hash persistence
• Collapsible Transaction Details with sticky headers and pinned totals
• Loading shell while Vue mounts
• report_fields config so captured fields like memo appear without per-rule passthroughs
• Layout preferences persisted in localStorage with a reset control
• Rule provenance popup improvements
• Starter title changed to Tally Spending Analysis

Behavior changes

Calling these out explicitly — they change what the report does, not just how it looks, and they aren't obvious from the diff:

• Chart clicks now toggle visibility instead of applying filters. Clicking a category pie segment or a category-by-month bar no longer adds a category/date filter. This is deliberate, not a dropped handler. (Reimagined charts and KPI experience [4/6] #101 then reworks it further, making Spending by Category an explicit filter surface with tri-state legend chips.)
• Available months now come from categoryView, so a month is no longer lost just because its merchant was excluded from every configured view.
• Section View percentages use a new denominator — filteredViewTotals.value.spending, computed per transaction — instead of whole-merchant include/exclude decisions derived from merchant tag unions, which could drop ordinary spending from the denominator in mixed-tag datasets.
• Blank captured fields no longer render, so the phantom +1 Memo indicator is gone.
• Rule field: directives that evaluate to empty now emit no field at all, rather than a field with a blank value. A field: directive runs for every transaction its rule matches, so a merchant whose rule captures a memo previously attached an empty memo to every transaction that didn't have one — which is what produced a +1 popup indicator on transactions with nothing in the popup. 0 and False are retained; only None and empty strings/lists/dicts are dropped. This affects the +N indicator, the dynamic extra_fields columns in CSV export, and report search — it does not affect rule matching, since field.<name> in a match expression reads captured columns from the data file, not values emitted by another rule's field: directive.

Mobile: this is a locally generated HTML file and I expect nearly all use to be desktop/large display. Several pre-existing mobile issues remain and are deliberately out of scope here.

Added while addressing review feedback

• Section percentages changed value. The denominator moved to a spending-only basis (above) but the numerator stayed a raw sum, so a section holding income, investment or transfers divided one basis by the other and could exceed 100%. Sections and categories now carry a spending-only subtotal computed with the same per-transaction classification, and the section percentage uses it. The per-merchant percentage inside a category is unchanged — both its halves are raw totals, so it was already self-consistent.
• An excluded date chip is no longer flipped to an inclusion. The date popover edits include-mode filters only: it will not rehydrate an excluded month or range into the pending set, and Apply no longer replaces chips it does not own.
• Dates the calendar does not have are rejected. 2/31/2026, month 13 and 99/99/2026 previously parsed and produced filter chips that could never match a transaction.
• A malformed date range in the URL hash no longer hangs the report. #+dr:garbage..garbage walked to the string NaN-NaN, which compares less than the malformed end value forever, growing an array without bound until the tab died.
• report_fields is validated. A bare report_fields: memo was iterated character by character and treated as four capture names; an empty report_fields: raised TypeError. A bare string is now accepted as the single name it plainly means, an empty value means none, and anything else is rejected by name.
• The report title is escaped and coerced. It reached both the loading shell's markup and the embedded spendingData script unescaped, and a non-string value such as title: 2025 raised TypeError. The title is now resolved once and stored back onto spendingData, so the static shell and the mounted app can no longer disagree — previously an untitled report visibly renamed itself on mount, because the two fallbacks were different strings.

The </ escaping applied to the embedded JSON covers every string in the payload, not just the title. Merchant descriptions come from user CSVs and had the same exposure, so this is not new to this branch.

Date Filtering

Loading State

Transaction Details

Stack

#	Branch	PR	Description	Diff
1	feature/globbing-documentation	#98	Glob pattern docs and CLI tests	from main
2	feature/report-json-determinism	#99	Deterministic report JSON	from PR98 · from main
3	feature/ui-tweaks	#100	Date filter, transaction details, per-txn tags	from PR99 · from main
4	feature/charts-reimagined	#101	Reimagined charts and KPIs	from PR100 · from main
5	feature/merchant-composite-keys	#102	Composite merchant keys	from PR101 · from main
6	feature/categorization	#103	Categorization review file	from PR102 · from main

Independent: feature/ci-repair — #97 — fixes fork PR builds.

[Copilot]

Pull request overview

Adds date filtering, transaction-detail controls, and per-transaction classification to the HTML report, alongside stacked glob and deterministic-JSON changes.

Changes:

• Adds date filters, persistent layout controls, transaction details, and chart updates.
• Introduces report_fields configuration and rule provenance display.
• Adds glob coverage and deterministic report serialization.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
tests/test_report_html.py	Covers report UI and date filtering.
tests/test_cli.py	Tests glob path support.
tests/test_analyzer.py	Tests determinism and report fields.
src/tally/templates.py	Updates starter configuration.
src/tally/spending_report.js	Implements report behavior and filtering.
src/tally/spending_report.html	Adds report controls and loading UI.
src/tally/spending_report.css	Styles the updated report.
src/tally/report.py	Builds report title and provenance data.
src/tally/parsers.py	Promotes configured captured fields.
src/tally/merchant_utils.py	Adds rule provenance metadata.
src/tally/merchant_engine.py	Suppresses empty computed fields.
src/tally/format_parser.py	Stores report-field configuration.
src/tally/config_loader.py	Resolves global and source report fields.
src/tally/commands/run.py	Deduplicates report source names.
src/tally/commands/reference.py	Documents report fields in CLI help.
src/tally/cli_utils.py	Updates starter settings generation.
src/tally/analyzer.py	Stabilizes tag ordering.
docs/reference.html	Documents report fields.
docs/formats.html	Documents globs and captured fields.
config/settings.yaml.example	Adds glob and report-field examples.

Suppressed comments (2)

src/tally/spending_report.html:90

• Each month option is a mouse-only div, making the primary date-selection control inaccessible from the keyboard. Render these as buttons and expose their selected state.

                            <div v-for="m in activeYearMonths" :key="m.key" class="month-cell"
                                 :class="{ selected: pendingMonths.has(m.key) }"
                                 :data-testid="'date-month-cell-' + m.key"
                                 @click="toggleDateItem({ type: 'month', key: m.key })">{{ m.label.split(' ')[0] }}</div>

src/tally/report.py:373

• The configured title is also inserted unescaped in the embedded-output branch. Titles containing < are parsed as markup, and closing tags can inject HTML into the generated report. HTML-escape the resolved title before either placeholder replacement.

        final_html = html_template.replace(
            '__REPORT_TITLE__', resolved_title
        ).replace(

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.