Skip to content

made SelectRows public + modernized syntax#3

Open
aneiosi-orange wants to merge 1 commit into
datumbrain:mainfrom
aneiosi-orange:main
Open

made SelectRows public + modernized syntax#3
aneiosi-orange wants to merge 1 commit into
datumbrain:mainfrom
aneiosi-orange:main

Conversation

@aneiosi-orange

Copy link
Copy Markdown

made DataFrame.SelectRows public because it's an extremely useful function

changed all instances of interface{} to any (shorter and recommended alias)

updated all for loop to use the recommended range syntax

replaced instances of sb.WriteString(fmt.Sprintf(... by the recommended fmt.Fprintf(&sb, ... syntax

replaced ++ increments by more descriptive += 1 syntax

all tests OK

@fahadsiddiqui

fahadsiddiqui commented Jul 14, 2026

Copy link
Copy Markdown
Member

Thanks for your work - however the recent version of otters (v1.0.6) has this covered. Please check. If there is more to it or any places I missed, feel free to resolve the conflicts in here and rebase with main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants