Bug fixes for HADR checks#1037
Draft
michele-tahay-kohera wants to merge 2 commits intodataplat:mainfrom
Draft
Conversation
The Find-DbaInstance returns an object for the browser service when there are multiple (named) instances on one machine. This makes the subsequent Get-DbaAvailabilityGroup call fail.
When an error occurs in getting AG info, the whole $result object should not be nullified
Author
|
This file was not present in the "development" branch, and I had no idea to which branch I could push my modifications... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes this PR brings
Remarks:
I tried following the instructions on how to test a PR, but did not manage to get the required result. The instructions were confusing for me:
I did test these changes in a custom version of HADR.Test1 file that I include in my DbaChecks project, they work there now and much less failed tests for that one server I had trouble with.