Relax urllib3 pin to >=1.26.18,<3.0a (allows CVE-fixed 2.7.0+) - #148
Open
Architect203 wants to merge 1 commit into
Open
Relax urllib3 pin to >=1.26.18,<3.0a (allows CVE-fixed 2.7.0+)#148Architect203 wants to merge 1 commit into
Architect203 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect
https://buildtools1.service-now.com/x_snc_defect_defect.do?sys_id=7b81a663837a435014977f647daad388&sysparm_stack=x_snc_defect_defect_list.do?sysparm_query=active=true
Problem
The current pin
urllib3>=1.15,<2.0ain setup.py hard-blocks installingurllib3 2.x alongside this SDK, preventing users from upgrading to
security-patched versions.
This range includes urllib3 versions affected by several known CVEs:
— fixed specifically in urllib3 2.7.0
Change
Relaxed the pin to
urllib3>=1.26.18,<3.0a, which:but only the already-patched 1.26.18+
Testing
Ran the full test suite on Python 3.11 with urllib3==2.7.0 installed:
182 passed, 1 skipped, no failures.