fix(backend): drop stale domain_id kwarg in Admin Team seeding - #729
Open
larsgeorge-db wants to merge 1 commit into
Open
fix(backend): drop stale domain_id kwarg in Admin Team seeding#729larsgeorge-db wants to merge 1 commit into
larsgeorge-db wants to merge 1 commit into
Conversation
PR #597 removed the legacy domain_id column from TeamDb (domains are now polymorphic via entity_domain_associations, entity_type='team'), but ensure_default_team_and_project still passed domain_id=None to the TeamDb constructor. SQLAlchemy's declarative constructor rejects unknown kwargs, raising TypeError -> StartupSeedError and aborting startup. The value was None anyway, so removing it is behavior-preserving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Startup fails after PR #597 with:
PR #597 removed the legacy
domain_idcolumn fromTeamDb(domain assignment is now polymorphic viaentity_domain_associations,entity_type='team'), butSettingsManager.ensure_default_team_and_projectstill passeddomain_id=Noneto theTeamDb(...)constructor. SQLAlchemy's declarative constructor rejects unknown kwargs, so seeding aborts and startup dies.Fix
Remove the stale
domain_id=Nonekwarg. It was passingNoneanyway, so this is behavior-preserving.ProjectDbnever haddomain_id, so it's unaffected.Testing
TypeError.