Skip to content

fix(access): cap approve/reject dialogs to viewport with internal scroll #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surojitchowdhury wants to merge 3 commits into
base: development
Choose a base branch
from
Open

fix(access): cap approve/reject dialogs to viewport with internal scroll #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
790dc41
fix(access): cap access dialogs to viewport with internal scroll (#687)
surojitchowdhury Aug 14, 2026
eb97982
Merge branch 'development' into fix/access-dialog-scroll-687
surojitchowdhury Aug 18, 2026
faf1bcd
Merge branch 'development' into fix/access-dialog-scroll-687
mvkonchits-db Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/frontend/src/components/access/handle-access-grant-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@ export default function HandleAccessGrantDialog({

return (
<Dialog open={isOpen} onOpenChange={onOpenChange}>
<DialogContent className="sm:max-w-[560px]">
<DialogHeader>
<DialogContent className="sm:max-w-[560px] flex flex-col max-h-[85vh] overflow-hidden">
<DialogHeader className="shrink-0">
<DialogTitle className="flex items-center gap-2">
<Shield className="h-5 w-5 text-primary" />
Handle Access Request
Expand All @@ -168,7 +168,7 @@ export default function HandleAccessGrantDialog({
</DialogDescription>
</DialogHeader>

<div className="space-y-4">
<div className="space-y-4 flex-1 overflow-y-auto px-1 -mx-1">
{/* Request Details */}
<div className="p-4 bg-muted/50 rounded-lg border space-y-3">
<div className="flex items-center gap-2">
Expand Down Expand Up @@ -287,7 +287,7 @@ export default function HandleAccessGrantDialog({
</div>
</div>

<DialogFooter className="gap-2 sm:gap-2 flex-col sm:flex-row">
<DialogFooter className="gap-2 sm:gap-2 flex-col sm:flex-row shrink-0">
<Button
variant="outline"
onClick={() => onOpenChange(false)}
Expand Down
10 changes: 6 additions & 4 deletions src/frontend/src/components/workflows/workflow-approval-response-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,17 +319,18 @@ export default function WorkflowApprovalResponseDialog({

return (
<Dialog open={isOpen} onOpenChange={onOpenChange}>
<DialogContent className="sm:max-w-md">
<DialogHeader>
<DialogContent className="sm:max-w-md flex flex-col max-h-[85vh] overflow-hidden">
<DialogHeader className="shrink-0">
<DialogTitle>{title}</DialogTitle>
<DialogDescription>{description}</DialogDescription>
</DialogHeader>
{loadingConfig ? (
<div className="flex items-center justify-center py-8">
<div className="flex flex-1 items-center justify-center py-8">
<Loader2 className="h-8 w-8 animate-spin text-muted-foreground" />
</div>
) : (
<>
<div className="flex-1 overflow-y-auto space-y-4 px-1 -mx-1">
{detailRows.length > 0 && (
<div className="rounded-md border bg-muted/30 p-3 space-y-1.5">
<div className="text-xs font-medium text-muted-foreground uppercase tracking-wide">
Expand Down Expand Up @@ -397,7 +398,8 @@ export default function WorkflowApprovalResponseDialog({
disabled={submitting}
/>
</div>
<DialogFooter className="gap-2 sm:gap-0">
</div>
<DialogFooter className="gap-2 sm:gap-0 shrink-0">
<Button
variant="destructive"
disabled={submitting}
Expand Down