Repository navigation
Docs/adcap poc requirements - #112
Closed
dariakrasavina wants to merge 5 commits into
Closed
dariakrasavina wants to merge 5 commits into
dariakrasavina wants to merge 5 commits into
Conversation
Add project_input_requirements/ capturing the GM VSSM Calibration ↔ Databricks Impulse POC: - ADCAP_POC_REQUIREMENTS.md — the ADCAP team's needs and expectations - ADCAP_POC_PROPOSAL.md — fit assessment, high-level approach, architecture - GM_TO_DATABRICKS_REQUIREMENTS.md — access + Impulse silver input contract GM must provide to get started Co-authored-by: Isaac <no-reply@databricks.com>
- Scope the POC to two of GM's three MF4 methods (SPOT reports and the GM KPI/Python tests); mark manual ETAS INCA/MDA analysis out of scope. - Document the SPOT report model driven by the Template Plots tab (1 row = 1 plot; 76 plots in the LS6 reference output). - Flag the one partial fit: SPOT 2D-histograms color cells by a per-cell Mean/Min/Max of a third signal Z, whereas Impulse Histogram2D is occupancy/weight-based — note remediation options. Co-authored-by: Isaac <no-reply@databricks.com>
…y asks Incorporate Impulse-team guidance (data model / ingestion docs): - Frame the input as only three tables (channels + tiny container_metrics / channel_metrics); container_id may be long/int/string if consistent. - Add RAW encoder RLE/INTERVAL and MF4 invalidation-bit -> is_plausible. - Reframe the connection decision: prefer a custom solver reading GM's narrow bronze directly (no pivot cost, full channel coverage) with the Stellantis precedent and Impulse-team support; reshape/SolverConfig as fallbacks; note the roadmap single-input-table solver. - Add a GM data-discovery ask list (bronze + pivoted-silver example data, silver column count, extra metadata inventory, bronze-access decision). - Update proposal architecture, phases, criteria, and next steps to match. Co-authored-by: Isaac <no-reply@databricks.com>
- Merge ADCAP_POC_REQUIREMENTS.md into ADCAP_POC_PROPOSAL.md (needs + why-it-fits + what-to-build + approach/architecture) and retire the requirements file; reconcile framing to the decided Option 1 (narrow "Silver Plus" from bronze via explode ETL; custom solver in reserve). - Add a Success Metrics placeholder section to the proposal. - Add PROJECT_CONTEXT.md as the source of truth (data model, hierarchy, decisions, scope, roles, open questions), distilled from the meeting notes; resolve value typing to raw/scaled/string + value_map. - Add IMPULSE_SCALING_AND_DESIGN.md (channels-table sizing, multi-table union, custom solvers, streaming, agents, value typing) from the Impulse EU team. Co-authored-by: Isaac <no-reply@databricks.com>
- Add DATA_AND_BUILD_FINDINGS.md: real bronze schemas (adcap_veh_eng_data, file_status), confirmed facts (group = sample-rate; epoch-seconds doubles; values 93% numeric / 7% enum / 0 text), the 5 client-selected files (container_id 6-10), the existing silver_plus_adcap_impulse_poc build (silver + gold, row counts, 3 gaps), and the GM boost/EGR test inventory (7 tests) mapped to Impulse events/aggregators. - PROJECT_CONTEXT: fold in verified facts (group, value typing, timestamp, metadata location, 5-file scope), point to the findings doc, note the existing build, and refresh open questions. Co-authored-by: Isaac <no-reply@databricks.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test Plan
Checklist