Skip to content

bundle/generate: read recorded state from DMS for in-place generate - #6588

Open
shreyas-goenka wants to merge 4 commits into
mainfrom
isaac/dms-generate-recorded-state
Open

bundle/generate: read recorded state from DMS for in-place generate#6588
shreyas-goenka wants to merge 4 commits into
mainfrom
isaac/dms-generate-recorded-state

Conversation

@shreyas-goenka

@shreyas-goenka shreyas-goenka commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This PR enables bundle generate to work with DMS.

shreyas-goenka and others added 2 commits September 9, 2026 15:04
The in-place `bundle generate --resource` flow resolved deployed resource
IDs from local state, which is only a tombstone when deployment-history
recording is on. Read the recorded resources from the deployment metadata
service instead via a shared OpenDirectStateForRead helper, so dashboard and
genie-space generate work under recording. Enables the DMS acceptance
variant for the three generate in-place tests.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 34dbadf

Run: 34457693273

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux 1 279 17 4:50
💚​ aws windows 1 281 15 5:01
💚​ azure linux 1 278 17 5:08
💚​ azure windows 1 280 15 4:37
💚​ gcp linux 1 279 17 5:00
💚​ gcp windows 1 281 15 5:27
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 6 slowest tests (at least 2 minutes):
duration env testname
4:42 gcp windows TestAccept
4:11 aws windows TestAccept
4:00 azure windows TestAccept
2:13 gcp linux TestAccept
2:09 azure linux TestAccept
2:08 aws linux TestAccept

Co-authored-by: Isaac <no-reply@databricks.com>
@shreyas-goenka
shreyas-goenka marked this pull request as ready for review September 10, 2026 08:52
@shreyas-goenka
shreyas-goenka requested review from denik and janniklasrose and removed request for denik September 10, 2026 08:52
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/bundle/ - needs approval

6 files changed
Suggested: @denik
Also eligible: @janniklasrose, @pietern, @andrewnester, @anton-107, @lennartkats-db

/cmd/bundle/ - needs approval

4 files changed
Suggested: @denik
Also eligible: @janniklasrose, @pietern, @andrewnester, @anton-107, @lennartkats-db

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @simonfaltum, @renaudhartert-db, @janniklasrose, @lennartkats-db, @rugpanov, @rclarey) can approve all areas.
See OWNERS for ownership rules.

Co-authored-by: Isaac <no-reply@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants