Remove duplicate sequence_fit < 0.60 check - #165
Open
nsheff wants to merge 2 commits into
Open
Conversation
Member
Author
|
@donaldcampbelljr I'm not sure if this was intentional; but it was confusing. can you glance and see what you meant here? |
Member
|
I believe this to be a typo. I suspect it is supposed to be tiered like so: |
Member
|
Here can be a clue if it was implemented correctly or not: |
Member
|
I think it won't influence our pipeline a lot, so LGTM |
| points_rating += 1 | ||
| if sequence_fit < 0.60: | ||
| points_rating += 1 | ||
| points_rating += 2 |
Member
There was a problem hiding this comment.
This is functionally the same as it was before; I recommend having three tiers and make the middle value ~ 0.75.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164
The
sequence_fit < 0.60check appeared twice, so a file below 0.60 scored +3 instead of +2. Removes the duplicate.