-
Notifications
You must be signed in to change notification settings - Fork 225
Add --coverage-package option
#2566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
|
@liamappelbe thank you! 🙂 Do you have an idea of when the next |
That's up to @natebosch. From my end, I'm fine publishing this asap. |
|
I have a few more changes I'd like to get out that have been slow to land internally. I expect I should have a release ready sometime next week. |
|
sgtm, thanks! |
|
@natebosch not a priority, but I saw you closed several of my other issues - are you still planning a release soon? |
I had intentions of getting another publish in this year and expected it to happen today. I've just hit some difficulty that I may cause it to slip until the new year when I return from some time off. The original reason I was holding off on release was to try to get #2543 landed in addition to the others changes and I had a harder time preparing for it that I anticipated. I decided to hold off on that and go forward with the publish today when I hit a tricker blocker. I filed #2579 with some discussion. It may still be the case that we can unblock a release soon, but I'm less confident. Sorry for the delays. |
|
@natebosch no worries, thanks for the update! It's definitely not a priority so don't push to do a release for me - mostly I was just trying to decide whether to include the related Dart-Code change in the upcoming release or bump to next month (I don't want to ship it without having tested it end-to-end with an actual published version). I'll just bump it until Jan instead. Thanks! |
At the moment
dart testonly ever gathers coverage data for the current package. But sometimes part of out test coverage comes from other packages, especially in the case of monorepos.To handle this case,
flutter testhas a--coverage-packageoption, which is a multi-option ofRegExps. When this option is present, we list all the transitive packages the current package depends on, and include them in the coverage report if they match any of theRegExps.This PR adds the exact same flag to
dart test.Fixes dart-lang/sdk#60958