Skip to content

Conversation

@brianquinlan
Copy link
Collaborator

@brianquinlan brianquinlan commented Dec 9, 2025

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@github-actions github-actions bot added the package:cupertino_http Issues related to package:cupertino_http label Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/http/example/main.dart
pkgs/http_multi_server/test/cert.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
cupertino_http Breaking 2.4.0 3.0.0-wip 3.0.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Coverage ⚠️
File Coverage
pkgs/cupertino_http/example/integration_test/url_session_task_test.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Comment on lines 216 to 217
// Add a small delay to allow cancellation to run before the request
// is completed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it feasible to coordinate the sequencing without an arbitrary delay? Should we wait on a Completer here and have the test body complete it after the cancellation runs? It will require edits in existing tests, but much better to be explicit about the interleaving.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood what was going on. I removed the delay and updated the documentation.

What is happening is that that cancel, when complete, transitions to the completed state. And that sometimes happens before we can observe the state as cancelled.

If this doesn't make the test reliable, I should probably just remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:cupertino_http Issues related to package:cupertino_http

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants