fix: use Database.Format for SQL escaping instead of g_hDB.Escape - #98
Open
Rushaway wants to merge 1 commit into
Open
fix: use Database.Format for SQL escaping instead of g_hDB.Escape#98Rushaway wants to merge 1 commit into
Rushaway wants to merge 1 commit into
Conversation
Database.Format escapes %s arguments automatically, avoiding a manual call+buffer per parameter and the extra driver/threading touchpoints from calling Escape directly.
This was referenced Aug 27, 2026
Closed
Contributor
Author
|
@darkerz7 Can it be merged ? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use
Database.Format()instead of manually callingg_hDB.Escape()on eachname buffer before building the query with
FormatEx(), inentwatch_logs_manager.sp.Database.Format()escapes%sarguments automatically, so the extraper-parameter
Escapecall + buffer (sz*_Name) is no longer needed. Thisremoves a driver/threading touchpoint per logged event and simplifies the
three DB handlers (
Item_Handler,Admin_Eban_Handler,Admin_Other_Handler).Behaviour is unchanged: the same values are escaped and inserted.
Notes
1.DZ.4->1.DZ.5.