Removed deprecated workflow operations#943
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 86.63% 88.05% +1.42%
==========================================
Files 84 103 +19
Lines 4473 7109 +2636
==========================================
+ Hits 3875 6260 +2385
- Misses 598 849 +251 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Albert Callarisa <albert@diagrid.io>
acroca
force-pushed
the
remove-deprecated-workflow-operations
branch
from
38bc4f8 to
0f9dda3
Compare
sicoyle
previously approved these changes
Mar 6, 2026
Contributor
sicoyle
left a comment
sicoyle
left a comment
There was a problem hiding this comment.
lgtm - thank you! Lets make this change in main to minimize 1.17 changes since we are post the official release (ie pls don't backport to 1.17 is my preference) 🙌
Signed-off-by: Albert Callarisa <albert@diagrid.io>
acroca
force-pushed
the
remove-deprecated-workflow-operations
branch
2 times, most recently
from
bc3aea6 to
c54aad2
Compare
Signed-off-by: Albert Callarisa <albert@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those operations have been deprecated for quite some time now.
@dapr/maintainers-python-sdk Thoughts on removing this? Should we do it for 1.17.1 or keep it in
mainfor 1.18?