Skip to content

Conversation

@lindner
Copy link
Contributor

@lindner lindner commented Feb 8, 2026

Summary

  • Adds a PATCH convenience constant to HttpExtension, matching the existing pattern for GET, PUT, POST, DELETE, etc.
  • Adds a test verifying the PATCH constant uses the correct HTTP method with empty query params and headers.

Test plan

  • Verify HttpExtensionTest.patchConstantShouldUsePatchHttpMethod passes

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: Paul Lindner <[email protected]>
@lindner lindner requested review from a team as code owners February 8, 2026 19:41
@lindner
Copy link
Contributor Author

lindner commented Feb 11, 2026

Anything I can do to get this reviewed?

Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lindner
Copy link
Contributor Author

lindner commented Feb 12, 2026

I don't have the ability to re-run the tests in CI; but I am 99% certain that this code is not the root cause.

@yaron2
Copy link
Member

yaron2 commented Feb 12, 2026

cc @salaboy

@salaboy salaboy merged commit 91cf080 into dapr:master Feb 12, 2026
10 of 11 checks passed
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.21%. Comparing base (ff5f43f) to head (870b2cf).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1644   +/-   ##
=========================================
  Coverage     79.20%   79.21%           
  Complexity     2141     2141           
=========================================
  Files           234      234           
  Lines          6455     6456    +1     
  Branches        700      700           
=========================================
+ Hits           5113     5114    +1     
  Misses          990      990           
  Partials        352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants