Merged
Conversation
Signed-off-by: Albert Callarisa <albert@diagrid.io>
sicoyle
reviewed
Mar 11, 2026
sicoyle
left a comment
sicoyle
left a comment
There was a problem hiding this comment.
ping me when you've addressed the build failures and we can send this. Thank you!!!
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Member
Author
|
I realised this change will change how we store even strings, as they were saved with quotes because of the |
expecting quotes here feels wrong. I am in favor of changing this. Thoughts @CasperGN ? |
|
It is a breaking change but imo it's not a bad one. I'm in favor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistency with other SDKs, we want to only support strings in the custom status field.
Ref: dapr/python-sdk#941