Enhance workflow management with runtime#5029
Conversation
…examples Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
| var daprGrpcPort = Environment.GetEnvironmentVariable("DAPR_GRPC_PORT") ?? "50001"; | ||
| var channel = GrpcChannel.ForAddress($"http://127.0.0.1:{daprGrpcPort}"); | ||
| var grpcClient = new TaskHubSidecarService.TaskHubSidecarServiceClient(channel); |
There was a problem hiding this comment.
I wonder if there's a way to pull these off of DaprClient instead.
There was a problem hiding this comment.
Doesn't look like it - perhaps it should be a feature but we can make it easier by piggybacking from the gRPC channel services.AddDaprWorkflow() already uses and DI TaskHubSidecarService.TaskHubSidecarServiceClient
There was a problem hiding this comment.
@WhitWaldo are we wrapping the RPC calls in the SDK?
Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
|
@WhitWaldo - Is this valid still? Do we want to recommend this way? |
I believe this implementation was started using the 1.16 version of the Dapr .NET SDK given that step 1 suggests that one creates a gRPC client and references the @MyMirelHub Typically, we don't advise people to go make a gRPC client and call into Dapr directly - that's the whole point of the SDKs to abstract that. I would wholeheartedly be willing to discuss adding another SDK package, e.g. |
|
@MyMirelHub - I suggest closing this PR. |
|
Closing in favour of discussing sdk management for workflow commands - a draft here dapr/dotnet-sdk#1738 |
Adds gRPC sidecar calls from dontet for new workflow commands