Skip to content

Enhance workflow management with runtime#5029

Closed
MyMirelHub wants to merge 2 commits intodapr:v1.17from
MyMirelHub:update-workflow-ops-docs
Closed

Enhance workflow management with runtime#5029
MyMirelHub wants to merge 2 commits intodapr:v1.17from
MyMirelHub:update-workflow-ops-docs

Conversation

@MyMirelHub
Copy link
Contributor

@MyMirelHub MyMirelHub commented Feb 4, 2026

Adds gRPC sidecar calls from dontet for new workflow commands

…examples

Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
@MyMirelHub MyMirelHub changed the title Enhance workflow management documentation with advanced features and … Enhance workflow management with runtime Feb 4, 2026
Comment on lines +541 to +543
var daprGrpcPort = Environment.GetEnvironmentVariable("DAPR_GRPC_PORT") ?? "50001";
var channel = GrpcChannel.ForAddress($"http://127.0.0.1:{daprGrpcPort}");
var grpcClient = new TaskHubSidecarService.TaskHubSidecarServiceClient(channel);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way to pull these off of DaprClient instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like it - perhaps it should be a feature but we can make it easier by piggybacking from the gRPC channel services.AddDaprWorkflow() already uses and DI TaskHubSidecarService.TaskHubSidecarServiceClient

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WhitWaldo are we wrapping the RPC calls in the SDK?

Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
@msfussell msfussell requested a review from WhitWaldo February 23, 2026 02:11
@msfussell
Copy link
Member

@WhitWaldo - Is this valid still? Do we want to recommend this way?
@MyMirelHub - THis is draft. Were you waiting on Whit?

@WhitWaldo
Copy link
Contributor

WhitWaldo commented Feb 23, 2026

@WhitWaldo - Is this valid still? Do we want to recommend this way? @MyMirelHub - THis is draft. Were you waiting on Whit?

I believe this implementation was started using the 1.16 version of the Dapr .NET SDK given that step 1 suggests that one creates a gRPC client and references the Dapr.DurableTask.Protobuf namespace. This namespace no longer exists as of 1.17 following the rewrite to remove all dependencies on DurableTask.

@MyMirelHub Typically, we don't advise people to go make a gRPC client and call into Dapr directly - that's the whole point of the SDKs to abstract that. I would wholeheartedly be willing to discuss adding another SDK package, e.g. Dapr.Workflow.Management or the like that embodies what it is you're expressing there, but SDK workaround feels like a bad user experience that really doesn't belong in the official documentation.

@msfussell
Copy link
Member

@MyMirelHub - I suggest closing this PR.

@MyMirelHub MyMirelHub closed this Feb 24, 2026
@MyMirelHub
Copy link
Contributor Author

MyMirelHub commented Feb 24, 2026

Closing in favour of discussing sdk management for workflow commands - a draft here dapr/dotnet-sdk#1738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants