Remove the workflows component abstraction - #4478
Open
JoshVanL wants to merge 8 commits into
Open
Conversation
The workflows package only ever defined an interface and its request/response types: no concrete component implementation ever existed in this repository. The single implementation lives inside dapr/dapr, which now uses the durabletask-go client directly, so the abstraction serves no purpose and makes client changes require updates to two repositories. Deletes the workflows package, its conformance test harness and config, and the workflows entries in the metadata utils, the metadata analyzer, the component metadata schema (regenerated), and the component folders list. Signed-off-by: joshvanl <me@joshvanl.dev>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unused workflows component abstraction from components-contrib (interface + request/response/metadata types) along with its conformance test scaffolding and associated metadata/schema tooling entries, since there is no concrete workflows component implementation in this repo and the dapr runtime no longer needs this abstraction.
Changes:
- Deleted the
workflowspackage (interface/types/docs) and workflows conformance tests/config. - Removed
workflowsfrom component-type metadata utilities, metadata analyzer generation, component folder list, and the component metadata JSON schema. - Regenerated schema-related artifacts to reflect the removed component type.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/workflow.go | Deletes the workflows component interface definition. |
| workflows/requests.go | Deletes workflows request type definitions. |
| workflows/responses.go | Deletes workflows response type definitions. |
| workflows/metadata.go | Deletes workflows metadata struct wrapper. |
| workflows/README.md | Removes workflows package documentation. |
| tests/conformance/workflows/workflows.go | Removes workflows conformance test harness. |
| tests/conformance/workflow_test.go | Removes workflows conformance test entrypoint. |
| tests/config/workflows/tests.yml | Removes workflows conformance test configuration. |
| metadata/utils.go | Removes workflows from the valid component types list. |
| component-metadata-schema.json | Removes workflows from the schema’s allowed type enum. |
| .build-tools/pkg/metadataschema/schema.go | Removes workflows from the schema generator’s type enum. |
| .build-tools/pkg/metadataanalyzer/utils.go | Removes workflows handling from metadata analyzer generator logic. |
| .build-tools/component-folders.yaml | Removes workflows from the component folders list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
113
to
115
| case "configuration": | ||
| method, methodFinderErr = getConstructorMethod("configuration.Store", parsedFile) | ||
| if methodFinderErr == nil { |
| // Component type, of one of the allowed values. | ||
| Type string `json:"type" yaml:"type" jsonschema:"enum=bindings,enum=state,enum=secretstores,enum=pubsub,enum=workflows,enum=configuration,enum=lock,enum=middleware,enum=crypto,enum=nameresolution,enum=conversation"` | ||
| Type string `json:"type" yaml:"type" jsonschema:"enum=bindings,enum=state,enum=secretstores,enum=pubsub,enum=configuration,enum=lock,enum=middleware,enum=crypto,enum=nameresolution,enum=conversation"` | ||
| // Name of the component (without the inital type, e.g. "http" instead of "bindings.http"). |
Comment on lines
208
to
212
| "bindings", | ||
| "state", | ||
| "secretstores", | ||
| "pubsub", | ||
| "workflows", | ||
| "configuration", |
javier-aliaga
previously approved these changes
Jul 29, 2026
The certification module embeds daprd, and dapr v1.18.0 still imports github.com/dapr/components-contrib/workflows, which this branch deletes, so every certification suite failed to build. Bump the dapr dependency to the master commit (dapr/dapr#10287) that uses durabletask-go directly. The go-sdk downgrade to v1.14.0-rc.2 is a forced cascade: go-sdk v1.15.0 requires dapr v1.18.0 or newer, which would override the pseudo-version pin. Signed-off-by: joshvanl <me@joshvanl.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4478 +/- ##
==========================================
+ Coverage 31.94% 32.14% +0.20%
==========================================
Files 353 352 -1
Lines 47723 37862 -9861
==========================================
- Hits 15243 12170 -3073
+ Misses 31277 24489 -6788
Partials 1203 1203 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
javier-aliaga
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflows package only ever defined an interface and its request/response types: no concrete component implementation ever existed in this repository. The single implementation lives inside dapr/dapr, which now uses the durabletask-go client directly, so the abstraction serves no purpose and makes client changes require updates to two repositories.
Deletes the workflows package, its conformance test harness and config, and the workflows entries in the metadata utils, the metadata analyzer, the component metadata schema (regenerated), and the component folders list.