Add --kubernetes flag to make dapr invoke cmd support kubernetes#862
Add --kubernetes flag to make dapr invoke cmd support kubernetes#862imneov wants to merge 37 commits intodapr:masterfrom
--kubernetes flag to make dapr invoke cmd support kubernetes#862Conversation
--kubernetes flag to make dapr invoke cmd support kubernetes mode--kubernetes flag to make dapr invoke cmd support kubernetes
--kubernetes flag to make dapr invoke cmd support kubernetes--kubernetes flag to make dapr invoke cmd support kubernetes
tanvigour
left a comment
There was a problem hiding this comment.
Can we add test case for this?
Sorry, just saw the reply. Thank you tanvigour for review. I wrote part of the test code. There may be problems with code style or edge cases. Please review. Welcome to add test cases. |
|
There is a problem with using So now our project(tkeel-io/cli#74) uses
This part of the implementation needs to modify |
--kubernetes flag to make dapr invoke cmd support kubernetes--kubernetes flag to make dapr invoke cmd support kubernetes
|
@imneov Can you signoff on your commits? https://github.com/dapr/cli/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-signing-your-work |
Signed-off-by: imneov <grantliu@yunify.com>
Signed-off-by: imneov <grantliu@yunify.com>
- related to dapr#779 Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Signed-off-by: imneov <grantliu@yunify.com>
Signed-off-by: imneov <grantliu@yunify.com>
Signed-off-by: imneov <grantliu@yunify.com>
Signed-off-by: imneov <grantliu@yunify.com>
Signed-off-by: imneov <grantliu@yunify.com>
|
@imneov Can you sign off all your commits ? https://github.com/dapr/cli/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-signing-your-work |
8d399b4 to
8df3681
Compare
|
@imneov Can you fix conflicts in the PR? |
Yes, I fix it. |
|
Thanks for the changes ... We will try to review this soon ... |
Signed-off-by: 柳丰 <grantliu@yunify.com>
Signed-off-by: 柳丰 <grantliu@yunify.com>
ad44543 to
9dad732
Compare
OK , Thanks for you reply. @pravinpushkar There is doc issue(dapr/docs#2846) and PR(dapr/docs#2847) |
|
@pravinpushkar Hi~ Is there any work I need to do? |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
mukundansundar
left a comment
There was a problem hiding this comment.
please add E2E for this feature.
|
@mukundansundar - What is happening with this issue/PR? |
|
@imneov - looks like there are some e2e failures, mind looking into and fixing those? That being said, given the time constraint for this release, I will push this to the next release |
Description
Support the invoke cmd on kubernetes mode.
The process is similar:
SubResource("proxy")ofRESTClientAppPortport or access to daprd'sHttpPortportIssue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[436] #[848]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: