Skip to content

DAOS-18281 dlck: make --storage argument obligatory #17206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daltonbohning merged 1 commit into from
Dec 9, 2025
Merged

DAOS-18281 dlck: make --storage argument obligatory #17206

daltonbohning merged 1 commit into from
Dec 9, 2025
+181 −0

Conversation

@janekmi
Copy link
Contributor

@janekmi janekmi commented Dec 1, 2025 •
edited
Loading

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@janekmi janekmi requested review from Nasf-Fan and rpadma2 December 1, 2025 23:11
@janekmi janekmi requested review from a team as code owners December 1, 2025 23:11
@janekmi janekmi added the CR Catastrophic Recovery Feature label Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

Ticket title is 'dlck --storage argument ought to be obligatory'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-18281

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 2, 2025

Test stage Unit Test on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17206/1/execution/node/639/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 2, 2025

Test stage Unit Test with memcheck on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17206/1/execution/node/641/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 2, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17206/1/testReport/

@janekmi janekmi force-pushed the janekmi/DAOS-18281-storage-obligatory branch from 35a4577 to 38539dd Compare December 2, 2025 11:37
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 2, 2025

Test stage Unit Test on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17206/2/execution/node/641/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 2, 2025

Test stage Unit Test with memcheck on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17206/2/execution/node/627/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 2, 2025

Test stage Unit Test on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17206/3/execution/node/399/log

@janekmi janekmi force-pushed the janekmi/DAOS-18281-storage-obligatory branch from 38539dd to 95b5e34 Compare December 2, 2025 16:55
@janekmi
Copy link
Contributor Author

janekmi commented Dec 5, 2025

Test results ✅

@janekmi janekmi requested a review from a team December 5, 2025 09:59
@daltonbohning daltonbohning merged commit 85615ee into master Dec 9, 2025
65 checks passed
@daltonbohning daltonbohning deleted the janekmi/DAOS-18281-storage-obligatory branch December 9, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@rpadma2 rpadma2 rpadma2 approved these changes

Assignees

No one assigned

Labels

CR Catastrophic Recovery Feature

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@janekmi @daosbuild3 @Nasf-Fan @rpadma2 @daltonbohning