Add explicit unsigned Windows release mode - #112
Merged
Conversation
Signed Windows publication stays blocked until a signing provider and WINDOWS_EXPECTED_SIGNER_SUBJECT are recorded, but provider onboarding is still pending and that gate currently blocks every release that wants to include Windows assets at all. Setting the WINDOWS_ALLOW_UNSIGNED_RELEASE repository variable to "true" now ships the raw EXE and MSI without Authenticode signatures: - package-windows stages the reviewed raw EXE and builds the MSI with -AllowUnsignedDevelopmentBuild instead of requiring a provider-signed helper, and records unsigned evidence with both hashes. - The Defender environment validation and controlled-runner scan are skipped; candidate assembly accepts the skipped scan only in unsigned mode and drops the Defender evidence expectation. - Candidate metadata records windowsSigning: unsigned, and publication revalidates that mode, requires the same repository-variable consent at publish time, and skips only the signature and Defender evidence checks. The protected windows-release-clearance approval still gates publication. - Unsigned mode refuses to run while a signer subject is configured, so the two modes cannot mix silently. With the variable unset, behavior is unchanged and fail-closed. Update the code-signing policy and release checklist to record the interim exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Signed Windows publication stays blocked until a signing provider and
WINDOWS_EXPECTED_SIGNER_SUBJECTare recorded — but provider onboarding is still pending, and that gate currently blocks any release from carrying Windows assets at all.This adds an explicit, opt-in unsigned mode: setting the
WINDOWS_ALLOW_UNSIGNED_RELEASErepository variable totrueships the raw EXE and MSI without Authenticode signatures.package-windowsstages the reviewed raw EXE and builds the MSI with-AllowUnsignedDevelopmentBuildinstead of requiring a provider-signed helper; it records unsigned evidence carrying both final hashes.windowsSigning: unsigned. Publication revalidates the mode, requires the same repository-variable consent at publish time, and skips only the signature/Defender evidence checks — the protectedwindows-release-clearanceapproval still gates publication, and all hash/byte-compare checks still run.Testing
actionlintv1.7.12 clean on both workflows.