Conversation
The charging list ordered strictly by date, which carries no time of day, so several sessions logged on one day came back in insertion order and the reading on the top row was not necessarily the vehicle's latest. Plug-in hybrids hit this routinely. Add odometer as a secondary sort key, mirroring the fix made for trips in #325. Closes #329 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughCharging session listings now sort by date descending, then odometer descending for matching dates. Tests cover both ordering rules. The README and changelog document the behaviour, and the application version changes to 0.38.2. ChangesCharging session ordering
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.38.2
A small fix to how charging sessions are ordered.
Fixes
Other
Note that the ordering applies to the charging list page. Charging sessions shown on the vehicle timeline and in the charging block on the fuel log page are still ordered by date alone.
Summary by CodeRabbit
Bug Fixes
Documentation
Release