Fix strawpoll embeds by changing URLs to HTTPS#1
Open
OliverCardoza wants to merge 1 commit intodanmux:masterfrom
Open
Fix strawpoll embeds by changing URLs to HTTPS#1OliverCardoza wants to merge 1 commit intodanmux:masterfrom
OliverCardoza wants to merge 1 commit intodanmux:masterfrom
Conversation
Visiting https://danmux.com/posts/the_cult_of_go_test/ does not display strawpoll embeds and prints the below error to the console. ``` Mixed Content: The page at 'https://danmux.com/posts/the_cult_of_go_test/' was loaded over HTTPS, but requested an insecure frame 'http://www.strawpoll.me/embed_1/1716206/r'. This request has been blocked; the content must be served over HTTPS. ``` This commit fixes by embedding strawpoll with https URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visiting https://danmux.com/posts/the_cult_of_go_test/ does not display strawpoll embeds and prints the below error to the console.
This commit fixes by embedding strawpoll with https URLs.
I know that it may be a bit weird to accept a PR on a personal blog. I don't mind if you make this commit yourself (I'm not seeking attribution), just felt this was the easiest way to suggest the fix.