Make redirection directives less confusing - #2889
Draft
waxlamp wants to merge 2 commits into
Draft
Conversation
This leaves the original material in place so as not to disrupt Netlify's live operations at the moment. A later PR will remove those after the Netlify apps have been repointed to the new locations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits apart the four redirects in
redirector/netlify.tomlinto four subdirectories, each handling one redirect. This better matches the structure of our redirection Netlify apps, of which there are four, and which currently rely solely on domain matching to execute the correct redirection rule.Reasons for doing this:
Reasons not to do this:
I am not sure whether this approach is better, if we should leave well enough alone, or if we should leave this as is and unify the Netlify apps into one. Accepting opinions 🙂
(Note: This leaves the original netlify.toml file in place so as not to disrupt Netlify's live operations at the moment. A later PR can remove that after the Netlify apps have been repointed to the new locations.)