fix: import migrate from dandischema.metadata - #2886
Merged
jjnesbitt merged 1 commit intoAug 13, 2026
Merged
Conversation
`dandischema` 0.12.0 stopped re-exporting `migrate` at the package root, so `from dandischema import migrate` has raised `ImportError` ever since. That makes `./manage.py migrate_published_version_metadata` fail immediately on startup, so the command cannot run at all. Nothing in the test suite imports this module, which is why the breakage went unnoticed. The sibling `migrate_version_metadata` command already uses the correct import path. Co-Authored-By: Claude Code 2.1.228 / Claude Opus 5 claude-opus-5 <noreply@anthropic.com>
jjnesbitt
approved these changes
Aug 13, 2026
Member
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./manage.py migrate_published_version_metadatafails at import time withImportErrorand cannot run at all.dandischema0.12.0 (dandi-schema#294) stopped re-exportingmigrateat the package root, but this command still doesfrom dandischema import migrate. The siblingmigrate_version_metadatacommand already uses the correctfrom dandischema.metadata import migrate.Nothing in the test suite imports this module, which is why it went unnoticed.
Test plan
ImportErroronmasterunder the currentdandischema==0.12.1pin, and that the module imports cleanly after the change.ruff checkandruff format --checkpass.