Add standard: search operator; remove file_type: - #2884
Open
bendichter wants to merge 1 commit into
Open
Conversation
This was referenced Aug 7, 2026
bendichter
force-pushed
the
search-operators-use-assets-summary
branch
from
August 7, 2026 15:36
884d1e9 to
b1db40f
Compare
standard: matches assetsSummary.dataStandard, the version-level roll-up of the data standards used by a dandiset's assets (e.g. NWB, BIDS). It was removed in 05fda3c pending a decision on the right metadata source; that decision is now made. file_type: is removed. Its remaining value is covered by standard:, and AssetsSummary has no encodingFormat or MIME field, so keeping it would have meant keeping the per-asset AssetSearch scan that the previous commit moved the other operators off of. Dropping it takes AssetSearch out of this code path entirely, which also lets apply_search_filters drop its user parameter: the remaining filters only ever narrow the caller's queryset, and detail routes re-check embargo_status in get_object. Since there is no close-enough operator for the generic "did you mean" suggestion to fire, file_type: now gets an explicit 400 pointing at standard: and the file type filter in the search sidebar. The faceted file_type query parameter is a separate feature and is untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bendichter
force-pushed
the
search-operator-standard
branch
from
August 14, 2026 20:57
35a0e2e to
b9413f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2882, which was pared down per review to just the performance fix. This PR carries the operator-set changes that were split out of it, and is stacked on that branch.
Re-Adding standard:
standard:was removed in 05fda3c pending a decision on the right metadata source. That decision is now made: it matchesassetsSummary.dataStandard, the same version-level aggregation that #2882 pointed the other operators at. Real entries are names like "Neurodata Without Borders (NWB)" and "Brain Imaging Data Structure (BIDS)", sostandard:nwbandstandard:bidsmatch by substring. Against production metadata,standard:nwbreturns 137 dandisets andstandard:bidsreturns 8.Removing file_type:
Its remaining value is covered by
standard:, andAssetsSummaryhas no encodingFormat or MIME field, so keeping it would have meant keeping the per-assetAssetSearchscan that #2882 moved the other operators off of. Dropping it takesAssetSearchout of this code path entirely, which in turn letsapply_search_filtersdrop itsuserparameter: the remaining filters only ever narrow the caller's queryset, and detail routes re-checkembargo_statusinget_objectbefore returning anything.There is no close-enough key for the parser's generic "did you mean" suggestion to fire on
file_type(the best ratio ismodified_afterat 0.52), so it now gets an explicit 400 pointing atstandard:and the file type filter in the search sidebar, with a test pinning that message.This removes only the search operator. The faceted
file_typequery parameter onDandisetSearchQueryParameterSerializeris a separate feature and is untouched.🤖 Generated with Claude Code