Reduce zarr stuckness - #2872
Merged
Merged
Conversation
This was an accidental overeager locking as a result of the select_related call. The dandiset doesn't need to be locked during this (relatively slow) transaction.
Member
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #2219.
It removes an accidentally introduced overbroad lock (#2111), and allows the ingestion of zarr archives to retry tasks when they fail due to deadlock, which is what happened with the latest slate of stuck zarrs.
The nature of ingesting zarrs makes for one long transaction (long as in seconds), which provides a large window of opportunity for simultaneous requests against the same resources to depend on each other.
I'd like to do a more thorough analysis of operations that conflict with each other, but for now this should significantly reduce the "zarr stuck in ingesting" problem - and otherwise there should be a deadlock error in sentry.