Allow modifying DALY charge/discharge limit parameters#2186
Open
M4GNV5 wants to merge 2 commits intodalathegreat:mainfrom
Open
Allow modifying DALY charge/discharge limit parameters#2186M4GNV5 wants to merge 2 commits intodalathegreat:mainfrom
M4GNV5 wants to merge 2 commits intodalathegreat:mainfrom
Conversation
M4GNV5
commented
Apr 1, 2026
Comment on lines
-406
to
-412
| "BATTCVMAX", "BATTCVMIN", "MAXPRETIME", "MAXPREFREQ", "WIFICHANNEL", "DCHGPOWER", "CHGPOWER", | ||
| "LOCALIP1", "LOCALIP2", "LOCALIP3", "LOCALIP4", "GATEWAY1", "GATEWAY2", "GATEWAY3", | ||
| "GATEWAY4", "SUBNET1", "SUBNET2", "SUBNET3", "SUBNET4", "MQTTPORT", "MQTTTIMEOUT", | ||
| "SOFAR_ID", "PYLONSEND", "INVCELLS", "INVMODULES", "INVCELLSPER", "INVVLEVEL", "INVCAPACITY", | ||
| "INVBTYPE", "CANFREQ", "CANFDFREQ", "PRECHGMS", "PWMFREQ", "PWMHOLD", "GTWCOUNTRY", | ||
| "GTWMAPREG", "GTWCHASSIS", "GTWPACK", "LEDMODE", "GPIOOPT1", "GPIOOPT2", "GPIOOPT3", | ||
| "INVSUNTYPE", "GPIOOPT4", "CTVNOM", "CTANOM", "CTATTEN", "PYLONBAUD", "PYLONBRAND", |
Contributor
Author
There was a problem hiding this comment.
looks like clang reformatted this. Sorry for including reformatting in feature PRs.
Contributor
Author
|
Had the time to build and OTA update. Everything seems to work fine, I was able to adjust the limit to 1.8kW at 10°C using the new web options. From my point of view this is ready for review/merge. 
|
|
Changes are loaded and running, as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR implements web-configurable options for charge limits of DALY BMS based batteries
Why
Previously hard coded, but need to be adapted to each battery individually, see #2183
How
Added 5 new options throughout the codebase.
Disclaimer: I did not see how to correctly add new web options (needed to change 6 files after all), so I tasked Claude to do it and only made some manual changes afterwards. The result looks fine, but needs testing. Maybe @KelasHA00 can test? Or someone else? Or myself when I am back home.