Draft: replace build_bench_env.sh with a Makefile#243
Draft: replace build_bench_env.sh with a Makefile#243derSteFfi wants to merge 82 commits intodaanx:masterfrom
Conversation
|
one ToDo I forgot in notes: tar can exclude files from extraction. The current shell-script does delete a few folders in a few repositories - we could modify the tar call to not extract them in the first place. |
This reverts commit 79118be.
mjp41
left a comment
There was a problem hiding this comment.
LGTM, thanks for the changes.
@jvoisin, @derSteFfi I don't want to hold these changes holding off on fixing issues for individual allocators/platforms. But I really like to only have a Green CI. Thoughts?
|
Absolutely agree. I still have at least scudo and lp on my list and will re-check all comments here afterwards. With that fixed, I would also be pro-merging to make it easier to hunt individual bugs. The branch-switching sometimes takes time, and we would have a clear stand - fixing individual things is much easier than to always have to model the whole process. |
0266c64 to
2d0082e
Compare
|
@jvoisin the MR is up-to-date with master - what do you think about merging? |
|
~All the tests are failing :/ |
the script tested for "../../build-bench-env.sh" to be present, which is now deleted. Check for "../../bench.sh" (this file) instead.
|
sorry, missed a reference to |
|
There are still a bunch of failures it seems |
|
these are the same we have on master, except that fedora is deactivated in the CI on master (don't remember why). alpine base container and ubuntu/tcg fail with master, too. |
pushing this draft as a starter to get your opinions - I'll be on vacation the next weeks and won't be working on it anyway. There are a few open tasks, but the general vibe should already come across. Feedback very welcome.
Decisions made:
TODO
put archives in extra storage after versionizing them (see here)docker caches these alreadyopen Questions: