Skip to content

Daanish Virani#1

Open
daanishvirani wants to merge 16 commits into
masterfrom
assignments
Open

Daanish Virani#1
daanishvirani wants to merge 16 commits into
masterfrom
assignments

Conversation

@daanishvirani
Copy link
Copy Markdown
Owner

No description provided.

@danawen
Copy link
Copy Markdown

danawen commented Jan 11, 2019

Hi Daanish. I took off some points in your Calculator assignment because all the functions were implemented in the same main method. Part of the assignment was to create a helper method for each of the arithmetic operations.

@danawen
Copy link
Copy Markdown

danawen commented Jan 23, 2019

Hi Daanish. I found a bug in your Tic Tac Toe assignment and took off some points:

  • The game does not inform the user in the event of a tie/draw (5 points)

@danawen
Copy link
Copy Markdown

danawen commented Jan 23, 2019

Hi Daanish. I couldn't find your Statistics code. It looks like you pushed an empty Statistics project into your Github repo.

@danawen
Copy link
Copy Markdown

danawen commented Jan 26, 2019

Hi Daanish, I got the Statistics.java file and graded your assignment. I found a bug and took off some points:

  • 10 pts: The average is incorrect. I entered 25,17,2,37 and the program output 20 for the average. The correct value is 20.25.
    If you fix this and would like to have it re-graded, let me know. Thanks!

@daanishvirani
Copy link
Copy Markdown
Owner Author

Hi Daanish, I got the Statistics.java file and graded your assignment. I found a bug and took off some points:

  • 10 pts: The average is incorrect. I entered 25,17,2,37 and the program output 20 for the average. The correct value is 20.25.
    If you fix this and would like to have it re-graded, let me know. Thanks!

@daanishvirani
Copy link
Copy Markdown
Owner Author

Hi Daanish, I got the Statistics.java file and graded your assignment. I found a bug and took off some points:

  • 10 pts: The average is incorrect. I entered 25,17,2,37 and the program output 20 for the average. The correct value is 20.25.
    If you fix this and would like to have it re-graded, let me know. Thanks!

@danawen I made the change in my program. It is now showing the average in the correct type. Let me know if it can still be regraded. Thanks

@danawen
Copy link
Copy Markdown

danawen commented Jan 29, 2019

Hi Daanish, I got the Statistics.java file and graded your assignment. I found a bug and took off some points:

  • 10 pts: The average is incorrect. I entered 25,17,2,37 and the program output 20 for the average. The correct value is 20.25.
    If you fix this and would like to have it re-graded, let me know. Thanks!

@danawen I made the change in my program. It is now showing the average in the correct type. Let me know if it can still be regraded. Thanks

@daanishvirani I re-graded it. Thanks!

@danawen
Copy link
Copy Markdown

danawen commented Mar 24, 2019

Hi @daanishvirani - I found a small bug when grading your final project. I added two items to the to-do list (ids 1 and 2). I deleted item 2, then added a new item (id 3). Then I tried to delete item 2, which I would expect to do nothing - but instead item 3 got deleted.
If you fix this bug and re-submit, let me know and I can re-grade it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants