Fix dependency update and test issues#190
Conversation
📝 WalkthroughWalkthroughThis PR updates project tooling deps (ruff -> v0.15.1, adds httpcore dev dep) and extends CytoDataFrame OME-Arrow handling: adds optional in-memory numpy-based conversions in Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/cytodataframe/frame.py (1)
1294-1360:⚠️ Potential issue | 🟡 MinorRemove unused
noqadirective from_extract_array_from_ome_arrowThe C901, PLR0911, and PLR0912 noqa codes are no longer triggered after the refactor and should be removed to keep lint clean.
🧹 Suggested cleanup
- def _extract_array_from_ome_arrow( # noqa: C901, PLR0911, PLR0912 + def _extract_array_from_ome_arrow(
jenna-tomkinson
left a comment
There was a problem hiding this comment.
LGTM! Just a small recommendation for more code comments if you think it would be helpful :)
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/cytodataframe/frame.py`:
- Line 1302: The function definition for _extract_array_from_ome_arrow contains
an unused noqa comment ("# noqa: C901, PLR0911, PLR0912") that Ruff flags;
remove the trailing "# noqa: C901, PLR0911, PLR0912" from the def line to clean
up lint warnings and keep the function signature otherwise unchanged.
|
Thanks @jenna-tomkinson ! Merging this in. |
Description
This PR addresses some issues which came up after merging #189 via dependency and test updates.
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.
Summary by CodeRabbit
New Features
Improvements
Tests
Chores