Skip to content

Conversation

@Likho
Copy link

@Likho Likho commented Mar 1, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (miscellaneous changes e.g. modifying .gitignore)
  • Build (Affect build components like build tool, ci pipeline, dependencies, project version)
  • Docs (documentation update)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes

  • Test A
  • Test B

Relevant notes

Notes about your pull request that may be useful for the reviewer

who-biz and others added 30 commits February 15, 2023 17:24
- Removes need to specify these as arguments to server on initialization
- Both config options have no effect on mainnet (added 'is_test_network()' boolean fn for checking)
- Above bulletpoint allows these flags to take effect only on AutomatedTesting, UserTesting, or Floonet ChainTypes
Add 'only_randomx' and 'no_progpow' options to config
Updates running.org doc with latest instructions
who-biz and others added 28 commits November 7, 2023 17:55
- Appears we do actually need to mutate this. This makes the only change removal of 'cycle()' member function on peers.iter()
- Essentially buckets the operations into more readable functions, removes unnecessary and hard-to-read code
- Maybe a small speedup here
- Because we are not looping through OrphanBlockPool recursively any longer, reducing this constant speeds up our sync
- And locks OprhanBlockPool RwLock for a lesser time period
- This is the same function as the original 'check_orphans' function in Grin
- We want to call it and loop through our full orphan list when we are within 120 blocks to chaintip, OR when our OrphanBlockPool is nearly full
- This combines efficiency of lock-avoidance in our new mechanics, while preserving benefits of loop logic in original function (but only calling when it makes sense to do so)
- We will start looping through orphans when orphan.len() >= 50
- We will stop looping when check_orphans_loop hits >= 29 iterations (first counted as 1, not 0)
- Same behavior, but adds 'outside_forced_pow_threshold' bool to make mechanics clearer
Improvements to BodySync portion of Sync phases
Version bump (3.5.0), update checkpoints to height 2.2M
- Also accomodate new semantics
- Also removes dependency on a git repository, instead using published crate
Update cursive dep to 0.17, tableview to 0.14.0
Update croaring dependency to 1.0.1, croaring-sys 1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants