Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
cyphar
force-pushed
the
ci-in-ctr
branch
28 times, most recently
from
c42e237 to
0bfd742
Compare
cyphar
force-pushed
the
ci-in-ctr
branch
4 times, most recently
from
fa366a5 to
b8c3ad0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
We made pretty judicious use of ?, which leads to problems if you have an error somewhere deep as there is little information at the error source about what was being attempted. The goal here is to just improve the overall amount of information we are providing when an error happens deep within some helper. This is really dumb grunt work so I used an LLM for parts of it. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
O_NOATIME requires privileges that we might not have and appears to be problematic in containers. O_NOCTTY is a better "dummy" flag to use. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
When we start running tests in containers, mknod(2) is blocked by the devices cgroup and so will fail even for root. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
When running in a container without CAP_SYS_ADMIN or with AppArmor enabled, you end up not being able to create namespaces or mount and it's not really easy to detect this at compile-time. This is just a hotfix because it fakes the test results to look like a pass, ideally we would be using the test-if crate I'm working on to let you do runtime conditional skipping. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
ci-in-ctr
branch
2 times, most recently
from
b399a1a to
26b317f
Compare
cyphar
force-pushed
the
ci-in-ctr
branch
2 times, most recently
from
773e935 to
57b65d9
Compare
This is really not an ideal solution but for now we should just skip the overmount tests if /proc/sys is already overmounted as the tests will fail when expecting no overmounts. The same goes for the sysctl unit tests, which expect /proc/sys to not be overmounted. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
This breaks under containers and there is no real need to use /proc/sys specifically for this test, though I guess we will eventually need to do skipping of e2e tests based on overmounts. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Minor quality of life improvement when running this script from inside a container. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
In a container we actually do run as root by default, so we should handle that case automatically in a similar way to --sudo. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
This will be needed to make it easier to exfiltrate test data from containers into a volume without making targets/llvm-cov-target a volume (which has some other potential downsides). Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
The primary use-case for this image is for CI, but I've included a very minimal install image that you could in principle use to make use of libpathrs on container infrastructure without needing to build it yourself. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372
Implements #376