Adds support for multi display type messages #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 24, 2025 14:46
clabland
approved these changes
Dec 2, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
added 2 commits
December 12, 2025 12:30
* develop: Bump version to 3.17.0 Review feedback Send opened inboxMessageAction events; add test harness config section Support marking unopened and unsubscribing from event emitter Send updated message list when marking opened or deleted lint Review feedback Support inbox messages fix and clean cleanpu non dry run to verify publishing works pare this down to only test npm publishing for now DX-809 update to use preferred OIDC for npm publish in github actions # Conflicts: # examples/index.html # src/managers/queue-manager.js
| message.properties.gist.exitClick = displaySettings.dismissOutsideClick; | ||
| } else { | ||
| delete message.properties.gist.exitClick; | ||
| } |
There was a problem hiding this comment.
Bug: Empty displaySettings clears custom message properties on restore
When displaySettings is an empty object {} (not undefined), saveMessageState saves it as-is. Later when restoring, applyDisplaySettings is called because savedState.displaySettings is truthy. Since all properties like maxWidth, overlayColor, and dismissOutsideClick are undefined in an empty object, the else branches execute and delete messageWidth, overlayColor, and exitClick from message.properties.gist. This causes custom styling to be lost when a persistent message is restored, falling back to defaults instead of preserving the original configuration.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: INAPP-14008
This PR adds support for multi-step display types and state saving between message step changes.
Note: gist-web-renderer/pull/32 Needs to be deployed first
Note
Adds multi-step message support with dynamic display switching (modal/overlay/inline), step/state persistence across sessions, and related utilities with a demo example.
changeMessageStep, detect display changes, apply/reload new settings (modal/overlay/inline) without duplicating events/views; prevent duplicates byqueueId; pass saved step to renderer.queueIdstep anddisplaySettings(30-day TTL) for persistent/show-always messages; clear state on dismiss/remove; adjust local-storage expiry to keep.statekeys.utilities/message-utils(fetch/update/remove by id, element lookup, display-type mapping, change detection,applyDisplaySettings,wideOverlayPositions); movefetchMessageByInstanceIdhere.MultiStepDisplayTypes) andstepId; supportstepNamein load; cleanupgist-*classes and styles on hide; enforce 100% width for wide overlay positions;addPageElementmade idempotent.examples/index.html.Written by Cursor Bugbot for commit 176361a. This will update automatically on new commits. Configure here.