Repository navigation
IS-11797 Rename pollingInterval config to defaultPollingInterval - #326
Merged
Merged
Conversation
aleixsuau
force-pushed
the
feature/dev/IS-11797-default-polling-interval
branch
from
September 11, 2026 07:58
355c59b to
2e56a88
Compare
aleixsuau
marked this pull request as ready for review
September 11, 2026 09:39
aleixsuau
force-pushed
the
feature/dev/IS-11797-default-polling-interval
branch
from
September 11, 2026 09:41
4af9982 to
fb90033
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Server interval validation accepts Infinity, which can cause immediate repeated polling.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Renames the HAAPI React SDK polling fallback configuration from pollingInterval to defaultPollingInterval, while prioritizing valid server-provided intervals.
Changes:
- Updates configuration types, defaults, mocks, and previewer usage.
- Adds interval precedence and validation tests.
- Updates polling integration tests and documentation.
File summaries
| File | Description |
|---|---|
src/haapi-react-sdk/haapi-stepper/util/tests/mocks.ts |
Updates test configuration and polling-step fixtures. |
src/haapi-react-sdk/haapi-stepper/feature/stepper/step-handlers/polling-step.ts |
Resolves server and default polling intervals. |
src/haapi-react-sdk/haapi-stepper/feature/stepper/step-handlers/polling-step.spec.ts |
Tests polling interval behavior and precedence. |
src/haapi-react-sdk/haapi-stepper/feature/stepper/HaapiStepper.tsx |
Applies the renamed default configuration. |
src/haapi-react-sdk/haapi-stepper/feature/stepper/HaapiStepper.spec.tsx |
Updates integration tests. |
src/haapi-react-sdk/haapi-stepper/feature/stepper/haapi-stepper.types.ts |
Renames and documents the configuration property. |
src/haapi-react-app/previewer/Previewer.tsx |
Updates preview configuration. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
luisgoncalves
approved these changes
Sep 11, 2026
| * | ||
| * Defaults to 3000. | ||
| */ | ||
| defaultPollingInterval: number; |
Contributor
There was a problem hiding this comment.
Nice to keep it simple.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://curity.atlassian.net/browse/IS-11797
Purpose & Context
pollingIntervalread like the value the app controls. It is not. A polling step'sproperties.intervalfrom the server always wins, and the app value is only the fallback. The logic is the more specific rule wins (step config > app config > default config). The rename todefaultPollingIntervalmakes that explicit.Today only BankID sends an interval (1000 ms). SMS, email and Duo polling steps do not, so they use this default.
Backend: no backend change. Works against
dev.How to Test & Review
Setup: a local identity server configured with
IDSVR_HOME=<dist> ./configure-idsvr-dev.shfromsrc/haapi-react-app/, andnpm run devrunning in that folder. The app is then served on https://localhost:8443.poll, then visit https://localhost:8443/dev/oauth/authorize?client_id=client-one&redirect_uri=https://localhost:7777/client-callback&response_type=code&state=random.bankid1,sms1andemail1.bankid1.sms1.Non-Functional Impact
Release note: HAAPI React SDK config
pollingIntervalrenamed todefaultPollingInterval.