Open
Conversation
microbundle-crl script is generating only cjs build This causes issues on the latest cra as well as custom build setup
Owner
|
Thank you for your contribution. I'll check it. |
cuongdevjs
reviewed
Feb 17, 2022
Owner
cuongdevjs
left a comment
cuongdevjs
left a comment
There was a problem hiding this comment.
Hi. Why do we need to change this? I've installed 2.0.1 our lib on my machine with CRA, I saw it work fine. I don't know why need this.
Contributor
Author
This is needed since the build is generating only cjs version which is mostly used on node servers since this library will be used 99% on client-side, most of the users need esm version which is what I have done and works on all setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix will not actually work for cra and custom webpack setup, since react app mostly use esm imports as well this package is not meant for server side rendering, esm will be quiet helpful. I've made a change so that the microbundle-crl will generate esm build files. I've tried to generate both esm and cjs bundles but unfortunately it's not working on microbundle-crl. It should be a breeze when using esbuild.
This will actually fix the module not exported error for many users. I confirmed it several times before the PR