Fix unit test failures in CI#165
Merged
Merged
Conversation
Collaborator
|
ERROR: Found 1 pep8 issue(s) which need to be resolved: |
Contributor
Author
|
Fixed in e35691d The blank lines left after removing test_no_templated_values have been reduced from 5 to 2. All lint checks pass now. |
Collaborator
|
…filter - Move the new API fields (webhook_key, webhook_ref_filter, webhook_service, max_retries) from no_api_parameter_ok to needs_param_development. no_api_parameter_ok only applies when the module has a parameter the API lacks; these are the opposite case (new API fields the modules do not support yet), which is exactly what needs_param_development is for. Also add job_slice_pinned_hosts, which was still failing. - Drop the IgnoreNaturalKeyFilter from export.py. Filtering the log message cannot fix the export (awxkit still drops the assets), and it would hide the genuine natural-key errors that mean the export is incomplete. The real fix is in awxkit (ctrliq/ascender#573).
Contributor
Author
|
I pushed a rework of the test fixes after looking closer at why the unit test job was still red:
Note the merge order: CI installs awxkit from the ascender default branch, so the unit test job here stays red until ctrliq/ascender#573 merges. With that PR applied to the ascender checkout, the full suite passes locally: 149 passed, including |
test_no_templated_values used to catch a mismatch between the hardcoded _COLLECTION_VERSION and galaxy.yml; it was dropped along with the other unit test fixes. Add test_collection_version_matches_galaxy_yml to keep that guarantee: it loads controller_api.py through the collection_import fixture and compares _COLLECTION_VERSION against galaxy.yml's version. Also update tools/README.md: the source no longer carries a 0.0.1-devel placeholder, it ships the real released version, so template_galaxy.yml is now only needed for non-default namespace builds or to stamp a different version at build time.
This was referenced Jul 9, 2026
cigamit
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_completenessby registering the new API fields introduced in Sync projects on repository push via webhooks ascender#563, Add automatic workflow node retries via a max_retries node setting ascender#564 and Allow pinning hosts to every slice of a sliced job ascender#565 (webhook_key,webhook_ref_filter,webhook_service,max_retries,job_slice_pinned_hosts) inneeds_param_development. These are new writable API fields that the modules do not support yet, so they now report as "Failed (non-blocking), parameter needs development" instead of failing the test, and they stay visible as pending module work. Also addcontroller_export_difftono_endpoint_for_moduleandtimeoutto thebulk_job_launchentry inno_api_parameter_ok.test_export_simpleis fixed on the awxkit side in Skip related endpoints without NATURAL_KEY during awxkit export ascender#573. The failure comes from awxkit erroring out on the newwebhook_keyrelated endpoints (noNATURAL_KEYdefined) and dropping every affected resource from the export. CI installs awxkit from the ascender default branch, so Skip related endpoints without NATURAL_KEY during awxkit export ascender#573 needs to merge before the unit test job here goes green.test_no_templated_values: this repo checks in the real collection version (25.4.0, matching galaxy.yml) rather than the templated placeholder, so the assertion tests a convention that no longer applies. Make thetemplate_galaxyregexes match any current value ("[^"]*") so they do not need per-release updates.<version>.Verification
With ctrliq/ascender#573 applied to the ascender checkout, the full unit test suite passes locally: 149 passed, including
test_completenessandtest_export_simple.