make filters for admin updates work#147
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="client/src/contexts/hooks/TableFilter.js">
<violation number="1" location="client/src/contexts/hooks/TableFilter.js:17">
P1: Date filters can now throw at runtime because `toISOString()` is called without validating parsed dates first.</violation>
</file>
<file name="client/src/components/updates/config/useUpdatesPageData.js">
<violation number="1" location="client/src/components/updates/config/useUpdatesPageData.js:13">
P2: Do not overwrite existing `item.status` in shared mapping; this breaks media status values like `Approved` used by filters.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
alexy-ok
left a comment
alexy-ok
left a comment
There was a problem hiding this comment.
For this one, could you format the filter to be like the one in programs table
|
gurt: yo |
fluffylenny
left a comment
fluffylenny
left a comment
There was a problem hiding this comment.
yay most of the filters work, just some small fixes needed w the update date filters :>
| before: (dataVal, filterVal) => new Date(dataVal) < new Date(filterVal), | ||
| after: (dataVal, filterVal) => new Date(dataVal) > new Date(filterVal), | ||
| toDateStr(dataVal) !== null && toDateStr(dataVal) === toDateStr(filterVal), | ||
| before: (dataVal, filterVal) => |
There was a problem hiding this comment.
fix: the "before" filter for update date doesn't work in some cases and displays updates made after and on the same day as the selected date.
| toDateStr(dataVal) !== null && | ||
| toDateStr(filterVal) !== null && | ||
| toDateStr(dataVal) < toDateStr(filterVal), | ||
| after: (dataVal, filterVal) => |
There was a problem hiding this comment.
fix: the "after" filter for update time doesn't work in some cases and still displays program updates from before and on the same day as the selected date.
3 participants
Description
Shoutout bug bash and Jen because the filter weren't actually doing anything so I fixed that
Screenshots/Media
Summary by cubic
Fixes broken filters on the Admin Updates page. Filters now work on both Program and Media tabs, with correct day-based date matching, invalid-date handling, and proper Status fallback.
UpdatesFilterPopoverto state and passedactiveFiltersto tables.statusvalues; derive "Resolved"/"Unresolved" only when missing.is,before,after) to compare by day (YYYY-MM-DD) and guard against invalid dates.Written for commit 3c279ba. Summary will update on new commits.