feat: support multi gRPC query clients serve with old binary (backport: #1603)#308
Open
mmsqe wants to merge 5 commits intocrypto-org-chain:release/v0.20.x-cronosfrom
Open
feat: support multi gRPC query clients serve with old binary (backport: #1603)#308mmsqe wants to merge 5 commits intocrypto-org-chain:release/v0.20.x-cronosfrom
mmsqe wants to merge 5 commits intocrypto-org-chain:release/v0.20.x-cronosfrom
Conversation
This reverts commit f3ffda3.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+334
to
+336
| for k, v := range data { | ||
| backupGRPCBlockAddressBlockRange[v] = k | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
Comment on lines
+17
to
+23
| for blocks, client := range b.backupQueryClients { | ||
| // b1-b2 -> g1 | ||
| // b3-b4 -> g2 | ||
| if int64(blocks[0]) <= height && int64(blocks[1]) >= height { | ||
| return client | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
Comment on lines
+198
to
+204
| for key, conn := range backupGRPCClientConns { | ||
| backend.backupQueryClients[key] = &rpctypes.QueryClient{ | ||
| ServiceClient: tx.NewServiceClient(conn), | ||
| QueryClient: evmtypes.NewQueryClient(conn), | ||
| FeeMarket: feemarkettypes.NewQueryClient(conn), | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
Comment on lines
+474
to
+492
| for k, address := range grpcBlockAddresses { | ||
| grpcAddr, err := parseGrpcAddress(address) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| c, err := grpc.Dial( | ||
| grpcAddr, | ||
| grpc.WithTransportCredentials(insecure.NewCredentials()), | ||
| grpc.WithDefaultCallOptions( | ||
| grpc.ForceCodec(codec.NewProtoCodec(clientCtx.InterfaceRegistry).GRPCCodec()), | ||
| grpc.MaxCallRecvMsgSize(maxRecvMsgSize), | ||
| grpc.MaxCallSendMsgSize(maxSendMsgSize), | ||
| ), | ||
| ) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| backupGRPCClientConns[k] = c | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
Codecov Report
@@ Coverage Diff @@
## release/v0.20.x-cronos #308 +/- ##
==========================================================
- Coverage 52.56% 52.43% -0.14%
==========================================================
Files 113 113
Lines 11073 11131 +58
==========================================================
+ Hits 5820 5836 +16
- Misses 5006 5045 +39
- Partials 247 250 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for more info
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)